Robust packet size calculations and garbage tests #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nyonson
commented
Oct 2, 2024
•
nyonson
commented
- Add a packet size calculator mainly in support of decoy packet allocations in the handshake, but useful in other spots as well.
- Split the 2 failures for garbage bytes.
nyonson
changed the title
nyonson
force-pushed
the
decoy-calc
branch
6 times, most recently
from
5c8779a to
0cea5d2
Compare
rustaceanrob
reviewed
Oct 7, 2024
nyonson
force-pushed
the
decoy-calc
branch
5 times, most recently
from
18b4cef to
de4a25e
Compare
nyonson
changed the title
|
Needs rebase, otherwise looks good |
|
ACK 75e49b5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.