Function name cosmetics and such #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustaceanrob
reviewed
Oct 2, 2024
| @@ -450,11 +450,11 @@ impl PacketWriter { | |||
| #[derive(Clone)] | |||
| pub struct PacketHandler { | |||
| /// A unique identifier for the communication session. | |||
| pub session_id: [u8; 32], | |||
There was a problem hiding this comment.
I was thinking it might be easier to have the field just be public, but I don't mind this approach either
|
ACK 380ed5a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with_allocsuffix tono_allocfollowing what will probably be used more. Closes Naming convention on methods #67 .PacketHandlersince I don't believe we want the caller to mess with them.contrib/directory for discoverability and following convention in rust-bitcoin.