Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fft library safe #75

Merged
merged 2 commits into from
Apr 20, 2020
Merged

Make fft library safe #75

merged 2 commits into from
Apr 20, 2020

Conversation

Luni-4
Copy link
Member

@Luni-4 Luni-4 commented Apr 18, 2020

This PR fixes the second item of #73 and makes the fft library safe

@Luni-4 Luni-4 requested a review from lu-zero April 18, 2020 23:13
dodomorandi
dodomorandi reviewed Apr 19, 2020
View reviewed changes
fft/src/fftwrap.rs Outdated Show resolved Hide resolved
fft/src/fftwrap.rs Outdated Show resolved Hide resolved
fft/src/fftwrap.rs Outdated Show resolved Hide resolved
fft/src/fftwrap.rs Outdated Show resolved Hide resolved
fft/src/fftwrap.rs Outdated Show resolved Hide resolved
@Luni-4
Copy link
Member Author

Luni-4 commented Apr 19, 2020

@dodomorandi

I have rewritten the API in the last commit, let me know if they are better according to you :)

@Luni-4 Luni-4 merged commit 08be1c0 into rust-av:master Apr 20, 2020
@Luni-4 Luni-4 deleted the fft-clean branch April 20, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dodomorandi dodomorandi dodomorandi approved these changes

@lu-zero lu-zero Awaiting requested review from lu-zero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Luni-4 @dodomorandi