-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken Link Checker - Github Action #2404
Broken Link Checker - Github Action #2404
Conversation
* Check links rupali-codes#2357 * chore: enable workflow_dispatch for check_links.yaml * test * broken links * json files * json files * path * False Positive URL * add False Positive URL * add False Positive URL
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, JuanPabloDiaz, for creating this pull request and contributing to LinksHub! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
@Anmol-Baranwal @CBID2 could you please review it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. What do you think @Anmol-Baranwal?
After completing the pull request, I realized it would be beneficial to extend the functionality by running the workflow whenever a pull request is opened to check the URLs as well. This feature is likely already configured in my workflow, but I haven't found a way to test it yet. |
I want a clear overview of how it works and what exactly you are trying to do. Will it open a PR if there are broken URLs in the repo? What exactly will happen? Just let me know so I can check the docs and necessary links to help. |
Sure @Anmol-Baranwal, This workflow is designed to automatically check for broken links in |
In addition... Link Checker:The Link Checker step reads the What Happens if Broken Links are FoundIf broken links are detected during any of the trigger events, the workflow will:
|
@JuanPabloDiaz |
@Anmol-Baranwal, I found a simpler workflow that we could use instead (it is clean and easy to understand). I test it in one of my projects and it does the job. |
Sure. I will check it out. Let's proceed with this one then. |
@rupali-codes Let's merge this quick! |
Fixes Issue
Closes #2357
Changes proposed
JuanPabloDiaz#39
Screenshots
Note to reviewers