Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve styling of various sections for light and dark theme #2344

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

Anmol-Baranwal
Copy link
Collaborator

Fixes Issue

closes #2247

Changes proposed

  • I've improved the styling of various sections for both the dark and light themes.
  • You can use this overview to check the live changes. I've attached it for reference.

Dark theme

Old New
image image
image image
image image
image image
image image
image image
image image
image image
image image

Light theme

Old New
image image
image image
image image
image image
image image
image image
image image
image image
image image

I might have missed some changes, so please check the deploy link to ensure everything is correct :)

Note to reviewers

Let me know what you all think. For me, this seems good for now.

@rupali-codes
Please hold off on merging this until the icons component PR is merged. Conflicts will arise anyway, so I'll take care of resolving them for this one.

Copy link

vercel bot commented Apr 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview Apr 13, 2024 5:31pm

@github-actions github-actions bot added goal: new-feature New feature or request priority: high Making completely new feature labels Apr 13, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Anmol-Baranwal, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@Anmol-Baranwal Anmol-Baranwal added the goal: new-design Design related issues label Apr 13, 2024
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rupali-codes rupali-codes merged commit 1c541b8 into main Apr 20, 2024
11 checks passed
@rupali-codes rupali-codes deleted the light-theme branch April 20, 2024 06:41
Copy link

Thank you for contributing to LinksHub! Please take a moment to rate this repo's DX on EddieHub's RepoRater and give it a star ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-design Design related issues goal: new-feature New feature or request priority: high Making completely new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] improvements in light and dark theme
3 participants