Closes #2302 #2305
Merged
Closes #2302 #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misochenk0
requested review from
Anmol-Baranwal,
CBID2,
rupali-codes and
aftabrehan
as code owners
|
Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel. @rupali-codes first needs to authorize it. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aftabrehan
approved these changes
Mar 18, 2024
aftabrehan
added
status: ready-to-merge
Closed
3 tasks
|
@Anmol-Baranwal please review this |
Anmol-Baranwal
approved these changes
Mar 21, 2024
|
@rupali-codes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
This pr closes #2302
Changes proposed
added findClosestScrollElement function inside useEffect on first render of pagination
that function will find closest scrolling element and use it for scrolling when user changes page
Use that behavior in order to prevent bugs in future when pagination could be implemented in any part of a project Or the main scrolling element will be changed
that fix prevents almost all future scrolling bugs here
Screenshots
Small screencast to demonstrate how it works now
Screencast from 03-17-2024 12:34:25 PM.webm
Note to reviewers
Thank you for opportunity to contribute to your project!
I open for any discussion feel free to ask any questions and leave comments)