Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeImages #1589

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Add FreeImages #1589

merged 1 commit into from
Aug 20, 2023

Conversation

Sriparno08
Copy link
Contributor

Fixes Issue

Closes #1569

Changes proposed

I have added a new image resource to the website.

Screenshots

image

@vercel
Copy link

vercel bot commented Aug 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2023 5:43am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Sriparno08, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBID2 CBID2 added goal: new-link Addition of new links related contributions quick-fix Shouldn't take much time to finish level1 Addition of new links/categories or doing any small task (e.g fixing typos) and removed level1 Addition of new links/categories or doing any small task (e.g fixing typos) labels Aug 11, 2023
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

A unique description would definitely be appreciated, as this can be described for other resources as well.

@Anmol-Baranwal Anmol-Baranwal added the status: ready-to-merge Approved & its ready-to-merge label Aug 19, 2023
@CBID2
Copy link
Collaborator

CBID2 commented Aug 19, 2023

🚀 Looks good to me.

A unique description would definitely be appreciated, as this can be described for other resources as well.

If you feel this way @Anmol-Baranwal, I highly recommend changing your review to request changes and implement some in-line comments to the description. It'll exemplify your idea clearly

@CBID2 CBID2 merged commit 48a7d68 into rupali-codes:main Aug 20, 2023
4 checks passed
@CBID2
Copy link
Collaborator

CBID2 commented Aug 20, 2023

Forget it @Anmol-Baranwal. I merged it! :) looks ok

@Anmol-Baranwal
Copy link
Collaborator

Yeah, we will update descriptions on our side soon. If it isn't catchy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-link Addition of new links related contributions quick-fix Shouldn't take much time to finish status: ready-to-merge Approved & its ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add] Image Resource
3 participants