Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility w/ IConfiguration #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mguinness
Copy link

I had to tweak the rule class to change Inputs field from IEnumerable to IList for compatibility w/ IConfiguration. I updated tests and also added section to README for details in use.

@jamescurran
Copy link
Contributor

I can't see how I'd implement the Inputs property without used a List<> or an array as the backing store, so this shouldn't be a problem.

@mguinness
Copy link
Author

mguinness commented Jan 23, 2021

If I need the opposite of IsInInput is there a way to do that other than creating a new expression like below?

case "NotInInput":
    return Expression.Not(Expression.Call(Expression.Constant(rule.Inputs.ToList()),
                            _miListContains.Value,
                            propExpression));

Or maybe add a new boolean field called Negate on Rule class that would invoke Expression.Not if true?

@mguinness
Copy link
Author

@jamescurran Do you think that this can be merged, do you need anything else from me?

@mguinness
Copy link
Author

@jamescurran Any update on if this change to support the JSON configuration provider can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants