Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile tests with riscof run #16

Merged
merged 10 commits into from
Jun 19, 2024
Merged

Compile tests with riscof run #16

merged 10 commits into from
Jun 19, 2024

Conversation

Scott-Guest
Copy link
Contributor

@Scott-Guest Scott-Guest commented Jun 14, 2024

  • Implement riscof_kriscv.py enough so that we can compile (but not execute) tests with riscof run
  • Remove the compilation logic from test_conformance.py, and instead call riscof run in make test-integration

Additionally,

  • Move the tests/riscof folder to src/tests/integration/riscof
  • Delete the sail_cSim reference plugin template
    • Nothing we are doing actually runs a reference plugin yet, we may not end up using sail_cSim, and the template would have required significant modification anyways, so no point leaving this checked-in

A few files get shuffled around, so I'd recommend reviewing this commit-by-commit.

@Scott-Guest Scott-Guest self-assigned this Jun 14, 2024
@Scott-Guest Scott-Guest requested a review from Baltoli June 15, 2024 00:00
@Scott-Guest Scott-Guest marked this pull request as ready for review June 15, 2024 00:00
@Scott-Guest Scott-Guest changed the title Clean up riscof plugin Compile tests with riscof run Jun 15, 2024
@Scott-Guest Scott-Guest marked this pull request as draft June 15, 2024 04:50
@Scott-Guest Scott-Guest marked this pull request as ready for review June 15, 2024 06:16
Copy link
Collaborator

@sskeirik sskeirik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall to me. I only did a quick perusal since I was busy today. I left a few possible nits to consider.

src/tests/integration/riscof/README.md Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@rv-jenkins rv-jenkins merged commit 993d7b9 into master Jun 19, 2024
3 checks passed
@rv-jenkins rv-jenkins deleted the test-reorg branch June 19, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants