Skip to content

Commit

Permalink
Continue on failure to pull / push from kaas caches (#11)
Browse files Browse the repository at this point in the history
* Removing the tag latest and moving to a tag system based on the version
of the file containing the test set being run i.e. run_kontrol.sh

If a download from the cache server fails this should not fail the test
overall. It will just take longer.

	modified:   .github/workflows/optimism-ci.yaml

* If uploading the latest cache fails it does not mean the test itself
failed. Do not stop or fail a test because this upload step failed.
  • Loading branch information
F-WRunTime authored Sep 19, 2024
1 parent ad6b3db commit 3900a8f
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions .github/workflows/optimism-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ on:
# Multiple Runs will need to be allowed to queue
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event.inputs.statuses_sha }}
cancel-in-progress: true
cancel-in-progress: false

jobs:
optimism:
Expand Down Expand Up @@ -106,9 +106,11 @@ jobs:
- name: "Download KCFG Cache Results"
shell: bash
continue-on-error: true
run: |
pushd optimism/packages/contracts-bedrock > /dev/null
kaas-cli download --token ${{ secrets.OPTIMISM_TOKEN }} runtimeverification/optimism-ci:latest -d ./kout-proofs/
tag=$(git hash-object ./test/kontrol/scripts/run-kontrol.sh)
kaas-cli download --token "${{ secrets.OPTIMISM_TOKEN }}" "runtimeverification/optimism-ci:$tag" -d ./kout-proofs/
- name: 'Run Kontrol'
shell: bash
Expand All @@ -123,10 +125,11 @@ jobs:
- name: 'KCFG Upload Cache Results'
shell: bash
if: always()
continue-on-error: true
run: |
pushd optimism/packages/contracts-bedrock > /dev/null
kaas-cli upload --token ${{ secrets.OPTIMISM_TOKEN }} runtimeverification/optimism-ci:${{ github.event.inputs.statuses_sha }} -d ./kout-proofs/
kaas-cli upload --token ${{ secrets.OPTIMISM_TOKEN }} runtimeverification/optimism-ci:latest -d ./kout-proofs/
tag=$(git hash-object ./test/kontrol/scripts/run-kontrol.sh)
kaas-cli upload --token "${{ secrets.OPTIMISM_TOKEN }}" "runtimeverification/optimism-ci:$tag" -d ./kout-proofs/
- name: 'Upload KCFG Results to Summary'
if: always()
Expand Down

0 comments on commit 3900a8f

Please sign in to comment.