UI/UX improvements #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbyalcinkaya
force-pushed
the
ui-ux-improvements
branch
from
0c31e33 to
f43b9f0
Compare
gtrepta
reviewed
Dec 18, 2024
src/komet/komet.py
Outdated
Comment on lines
50
to
52
| _exec_test(wasm=wasm, id=args.id) | ||
| if args.max_examples < 1: | ||
| raise ValueError(f'--max-examples must be a positive integer (greater than 0), given {args.max_examples}') | ||
| _exec_test(wasm=wasm, max_examples=args.max_examples, id=args.id) |
There was a problem hiding this comment.
Is there a way to run unlimited examples? I think this option ends up getting sent to hypothesis, it might have support for supplying 0 or -1 for that, you'll have to check.
There was a problem hiding this comment.
Hypothesis complains when it is less than 1:
hypothesis.errors.InvalidArgument: max_examples=-1 should be at least one. You can disable example generation with the `phases` setting instead.
Comment on lines
+241
to
244
| def deploy_and_run( | ||
| self, contract_wasm: Path, child_wasms: tuple[Path, ...], max_examples: int = 100, id: str | None = None | ||
| ) -> None: | ||
| """Run all of the tests in a soroban test contract. |
There was a problem hiding this comment.
Please update the docstrings.
bbyalcinkaya
force-pushed
the
ui-ux-improvements
branch
from
9691bd1 to
ecb827a
Compare
gtrepta
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following command line arguments:
--max-examples MAX_EXAMPLES: Maximum number of inputs for fuzzing (default: 100)--id ID: Name of the test function in the testing contract--directory DIRECTORY,-C DIRECTORY: The working directory for the command (defaults to the current working directory).