Implement ScVal comparison #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtrepta
reviewed
Dec 16, 2024
Comment on lines
+435
to
+440
| | compareString(String, String) [function, total, symbol(compareString)] | ||
| // --------------------------------------------------------------------------------------------- | ||
| rule compareBytes(A, B) => compareString(Bytes2String(A), Bytes2String(B)) | ||
| rule compareString(A, B) => Less requires A <String B | ||
| rule compareString(A, B) => Equal requires A ==String B | ||
| rule compareString(A, B) => Greater requires A >String B |
There was a problem hiding this comment.
It looks like the tests you added don't test string/bytes comparisons. Have you also verified that our semantics for String comparisons matches the comparisons for strings/bytes in soroban?
There was a problem hiding this comment.
@gtrepta I added a komet test for Bytes comparison after your review. I also implemented a new host function, bytes_copy_to_linear_memory, to support this test.
gtrepta
approved these changes
Dec 18, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented value comparison (CAP 46-01) and the
obj_cmphost function.