Handle KLLVM.StringBuffer.contents as bytes and enable unicode tests in String contructors
#4567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robertorosmaninho
requested review from
gtrepta,
tothtamas28 and
Scott-Guest
and removed request for
gtrepta
|
These commits will be squashed and committed to #4565 as they block that PR and depend on the changes there. However, as this changes important parts of PyK, I would like your thoughts about it @tothtamas28, @gtrepta, and @Scott-Guest. I've tested it also on KEVM, and everything looks good there |
tothtamas28
reviewed
Aug 6, 2024
Robertorosmaninho
force-pushed
the
Fix-Bytes-KLLVM-PArsing
branch
from
23ad066 to
7ab90da
Compare
|
@tothtamas28 and @Scott-Guest, can you please review the PR again? If you approve it, I'll cherry-pick the commit and put it in #4565 so the tests pass as expected there, and we can merge both changes. |
tothtamas28
approved these changes
Aug 7, 2024
Modifying string tests to only test non-unicode string for bindings. Decoding `pattern.contents` in `test_string`
Robertorosmaninho
force-pushed
the
Fix-Bytes-KLLVM-PArsing
branch
from
48d7fec to
39a44a9
Compare
Scott-Guest
approved these changes
Aug 7, 2024
|
Closing as this modification was merged with #4565 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #1126.
Related to:
StringPattern.contentsis broken llvm-backend#824UnicodeDecodeErroron non-utf bytes in terms of sortBytesllvm-backend#1078This PR aims to support the new feature introduced in #1126 that makes
KLLVM.StringBuffer.contentsreturnsbytes. To ensure the symmetric behavior, we should also construct theKLLVM.StringBufferobject with bytes. To ensure this feature works properly, we're usingraw_unicode_escapeencoding to pass and retrieve the result.This can be used as a first step in a new attempt to support Unicode!