Set logging level to DEBUG for llvm_interpret_raw
#4518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `PurePath.is_relative_to` from `pathlib`.
tothtamas28
commented
Jul 12, 2024
Comment on lines
-652
to
-656
| # Implementation because of outdated Python versions: https://github.com/python/cpython/blob/1de4395f62bb140563761ef5cbdf46accef3c550/Lib/pathlib.py#L554 | ||
| def is_relative_to(_self: Path, other: Path) -> bool: | ||
| return _self == other or other in _self.parents | ||
|
|
||
|
|
There was a problem hiding this comment.
This is an unrelated cleanup, but since it is straightforward to adjust for in dependents I decided to include it in this PR.
tothtamas28
force-pushed
the
llvm-interpret-logging
branch
from
370bad2 to
a8faa71
Compare
tothtamas28
force-pushed
the
llvm-interpret-logging
branch
from
a8faa71 to
80135c8
Compare
gtrepta
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4516
logleveltorun_process_2.logleveltoDEBUGforllvm_interpret_raw. This is a more reasonable choice thanINFO, since we only need this information for diagnosing problems.loggerto the logger of the host module forllvm_interpret_raw. This enables finer grained configuration from the application.