Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adopt: #4504] README: Add libunwind-dev to list of dependencies for Debian #4512

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

Baltoli
Copy link
Contributor

@Baltoli Baltoli commented Jul 10, 2024

Without this installed the build on Debian still works, but the following error is produced when you try to run kompile:

ld.lld: error: unable to find library -lunwind
clang: error: linker command failed with exit code 1...

There is no need to rebuild the K framework after installing libunwind-dev; it's just the shared library in its dependency libunwind8 that we need to fix this. (But we use libunwind-dev in the README anyway for consistency.)

This is apparently not seen on MacOS, probably because -lunwind because it's a part of LLVM there.

This is an adopted PR from @0cjs (#4504)

Without this installed the build on Debian still works, but the
following error is produced when you try to run `kompile`:

    ld.lld: error: unable to find library -lunwind
    clang: error: linker command failed with exit code 1...

There is no need to rebuild the K framework after installing
`libunwind-dev`; it's just the shared library in its dependency
`libunwind8` that we need to fix this. (But we use `libunwind-dev`
in the README anyway for consistency.)

This is apparently not seen on MacOS, probably because -lunwind
because it's a part of LLVM there.
Copy link
Contributor

@gtrepta gtrepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we know why this wasn't an issue before? I recall having the -lunwind error on my machine and installing this package to fix it a few weeks ago, it was a bit of a mystery that I simply forgot about.

@Baltoli
Copy link
Contributor Author

Baltoli commented Jul 10, 2024

Do we know why this wasn't an issue before?

Dwight only added it as an dependency of the LLVM backend recently.

@rv-jenkins rv-jenkins merged commit 4a5587c into develop Jul 10, 2024
18 checks passed
@rv-jenkins rv-jenkins deleted the adopt-pr-4504 branch July 10, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants