Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to run actionlint #4468

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Add workflow to run actionlint #4468

merged 3 commits into from
Jun 24, 2024

Conversation

tothtamas28
Copy link
Contributor

@tothtamas28 tothtamas28 commented Jun 21, 2024

actionlint is a static checker for GitHub Actions workflow files. This PR adds a workflow that runs actionlint to check .yml files in .github/workflows. It also cleans up some issues flagged by shellcheck, a linter for shell scripts actionlint calls out to.

@tothtamas28 tothtamas28 self-assigned this Jun 21, 2024
@tothtamas28 tothtamas28 force-pushed the actionlint branch 2 times, most recently from 4bcd655 to 2765f5b Compare June 21, 2024 13:35
echo "path_remote=${BOTTLE_NAME}" >> ${GITHUB_OUTPUT}
LOCAL_BOTTLE_NAME=$(basename "$(find . -name "kframework--${VERSION}.arm64_sonoma.bottle*.tar.gz")")
# shellcheck disable=2001
BOTTLE_NAME=$(echo "${LOCAL_BOTTLE_NAME#./}" | sed 's!kframework--!kframework-!')
Copy link
Contributor Author

@tothtamas28 tothtamas28 Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, the most important thing to note is

${LOCAL_BOTTLE_NAME#./}

became

"${LOCAL_BOTTLE_NAME#./}"

@tothtamas28 tothtamas28 marked this pull request as ready for review June 21, 2024 14:13
@tothtamas28 tothtamas28 requested a review from a team as a code owner June 21, 2024 14:13
@Baltoli Baltoli merged commit 1ee5abb into develop Jun 24, 2024
18 checks passed
@Baltoli Baltoli deleted the actionlint branch June 24, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants