CI: Don't tell pytest to try to kill the integration tests on failure #4371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baltoli
reviewed
May 21, 2024
Baltoli
approved these changes
May 21, 2024
rv-jenkins
added a commit
that referenced
this pull request
May 22, 2024
Does the same as #4371, but without modifying code generated from the Python project template. --------- Co-authored-by: rv-jenkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug with
pytest-xdistwhere using multiple runners doesn't properly terminate the test run when there's a failure and--maxfail=1has been passed. Instead, the runner that ran the failed test exits and the remaining runners continue. What this results in on CI is the remaining runners are not able to finish the integration tests before the timeout for the job, killing pytest before it can finish and report the reason for the failed test.This change removes the
--maxfailoption when running on CI, so when there's a test failure, all of the runners continue, so they should be able to finish before the timeout and pytest can properly finish and report the failure reason(s).