Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyk RPC: bug-report w/o dt dir #4340

Merged
merged 6 commits into from
May 14, 2024
Merged

pyk RPC: bug-report w/o dt dir #4340

merged 6 commits into from
May 14, 2024

Conversation

jberthold
Copy link
Member

@jberthold jberthold commented May 13, 2024

The llvm_definition/dt directory in the bug report is not necessary (any more), and is usually very big.
Closes runtimeverification/kasmer-multiversx#98

@rv-jenkins rv-jenkins changed the base branch from master to develop May 13, 2024 04:06
@jberthold jberthold marked this pull request as ready for review May 13, 2024 12:24
@jberthold jberthold requested review from tothtamas28 and ovatman May 13, 2024 12:24
@ehildenb
Copy link
Member

The logs are used to display the list of rules used to make an edge in the KCFG. Why does logging this information make the backend hold onto large amounts of memory? Can that be fixed on the backend side? It should just be a list of hashes.

@ehildenb
Copy link
Member

Is that memory being held in Kore or in booster?

@jberthold
Copy link
Member Author

Is that memory being held in Kore or in booster?

Both are collecting information during rewriting. In kore, we might still be collecting the intermediate terms that were once part of the log.
We were planning to phase out the log options in the requests but if they are required we need to keep them. I will reduce the amount of information. Will back out this change from the PR then.

@tothtamas28
Copy link
Contributor

Will back out this change from the PR then

Please also adjust the title and description as they are going to be part of the commit message.

@jberthold jberthold changed the title Adjustments to pyk RPC: logs optional, bug-report w/o dt dir pyk RPC: bug-report w/o dt dir May 14, 2024
@rv-jenkins rv-jenkins merged commit 0e2f39d into develop May 14, 2024
17 checks passed
@rv-jenkins rv-jenkins deleted the jb/pyk-rpc-fixes branch May 14, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants