Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NULL return from requires binding of get_requires() #4326

Merged
merged 3 commits into from
May 8, 2024

Conversation

Robertorosmaninho
Copy link
Collaborator

The llvm function get_requires() can return either the Pattern in the requires clause or nullptr. However, our binding only accepted the first case, and this PR fixes that behavior by testing if the result of axiom.requires returned a pattern. If not, we return None instead of trying to convert None to a LLVM Pattern.

A unit test was added to ensure this behavior was documented and tested.

@Robertorosmaninho Robertorosmaninho self-assigned this May 8, 2024
@rv-jenkins rv-jenkins changed the base branch from master to develop May 8, 2024 17:56
@rv-jenkins rv-jenkins merged commit 313aaba into develop May 8, 2024
17 checks passed
@rv-jenkins rv-jenkins deleted the fix-get_requires branch May 8, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants