Support NULL return from requires
binding of get_requires()
#4326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The llvm function
get_requires()
can return either the Pattern in the requires clause or nullptr. However, our binding only accepted the first case, and this PR fixes that behavior by testing if the result ofaxiom.requires
returned a pattern. If not, we return None instead of trying to convert None to a LLVM Pattern.A unit test was added to ensure this behavior was documented and tested.