Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --kore-rpc-command option to pyk prove #4296

Merged
merged 2 commits into from
May 2, 2024

Conversation

geo2a
Copy link
Contributor

@geo2a geo2a commented Apr 30, 2024

Somehow the --kore-rpc-command option has disappeared from pyk prove, so this PR is bringing it back.

@rv-jenkins rv-jenkins changed the base branch from master to develop April 30, 2024 14:14
@geo2a geo2a added the pyk label Apr 30, 2024
@ehildenb
Copy link
Member

@geo2a you need to rebase on develop directly, and remove the changes that came in from master.

@ehildenb
Copy link
Member

Also, please have @nwatson22 confirm that this is the intended way to use the CLI. He designed the new parameter system, and I believe it requires more changes than this.

@ehildenb ehildenb requested a review from nwatson22 April 30, 2024 14:19
@geo2a geo2a force-pushed the georgy/pyk-prove-add-missing-options branch from c03e749 to 2cc1a5f Compare April 30, 2024 14:33
@geo2a
Copy link
Contributor Author

geo2a commented Apr 30, 2024

Thanks @ehildenb, I've rebased and force-pushed.

@nwatson22 could you have a look at the PR and advise if I need to add the argument somehow differently? Also, I'd appreciate an advice on how to add --bug-report to pyk prove.

@nwatson22
Copy link
Member

This looks good. The --kore-rpc-command option seems to have just been removed from the argparse section, not from ProveOptions, so I don't think anything else needs to be done. To add --bug-report, I would add k_cli_args.bug_report_args to the parents here:

    prove_args = pyk_args_command.add_parser(
        'prove',
        help='Prove an input specification (using RPC based prover).',
        parents=[k_cli_args.logging_args, k_cli_args.spec_args, config_args.config_args],
    )

and add BugReportOptions to the list of inherited classes in ProveOptions here:

class ProveOptions(LoggingOptions, SpecOptions, SaveDirOptions):

@geo2a geo2a added the automerge label May 2, 2024
@geo2a
Copy link
Contributor Author

geo2a commented May 2, 2024

Thanks @nwatson22!

@rv-jenkins rv-jenkins merged commit aa8e13b into develop May 2, 2024
17 checks passed
@rv-jenkins rv-jenkins deleted the georgy/pyk-prove-add-missing-options branch May 2, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants