Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit user-defined parametric sorts #3878

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Prohibit user-defined parametric sorts #3878

merged 2 commits into from
Dec 15, 2023

Conversation

Scott-Guest
Copy link
Contributor

This PR adds a check to error on any non-MInt parametric sorts.

We already assume MInt is the only parametric sort internally, so this check just makes that explicit to the user:

// TODO: for now we only have `MInt{Widht}` as parametric sorts, so we can treat it as a corner

The check has to be done in Module.checkSorts so that we error early enough, e.g., before computing the subsort POSet.

@Scott-Guest Scott-Guest self-assigned this Dec 14, 2023
@Scott-Guest Scott-Guest marked this pull request as ready for review December 14, 2023 22:21
@rv-jenkins rv-jenkins merged commit 322f223 into develop Dec 15, 2023
8 checks passed
@rv-jenkins rv-jenkins deleted the sort-parameters branch December 15, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants