Move id field out of ProductionReference into TypeInferencer
#3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scott-Guest
force-pushed
the
tree-nodes
branch
from
6bf3539 to
e794277
Compare
Scott-Guest
changed the title
treeNodes.scalaid field out of ProductionReference into TypeInferencer
Baltoli
approved these changes
Nov 27, 2023
dwightguth
approved these changes
Nov 27, 2023
radumereuta
approved these changes
Nov 27, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
idfield ofProductionReferenceis only used byTypeInferencer, so this PR removes the field and instead stores it as aMap<ProductionReference, Integer>withinTypeInferencer.This is useful for testing the new type inference algorithm - both algorithms can be run back-to-back on the same term to compare results, with them each tracking the
idinternally rather than mutating the input and storing conflictingids.Additionally, I formatted
treeNodes.scalaand fixed all IntelliJ warnings.