Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proof hint generation flag #3821

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Add proof hint generation flag #3821

merged 3 commits into from
Nov 20, 2023

Conversation

Baltoli
Copy link
Contributor

@Baltoli Baltoli commented Nov 17, 2023

This flag exists in llvm-kompile already, but we want consumers that compile via the K frontend to be able to use the proof hint instrumentation feature.

@Baltoli Baltoli requested review from theo25 and gtrepta November 17, 2023 17:16
theo25
theo25 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@theo25 theo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

gtrepta
gtrepta requested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@gtrepta gtrepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a regression test that uses this flag, runs the interpreter with proof output, and just checks that the HINT header is present in the output?

@gtrepta gtrepta self-requested a review November 20, 2023 17:21
@rv-jenkins rv-jenkins merged commit 926981f into develop Nov 20, 2023
8 checks passed
@rv-jenkins rv-jenkins deleted the proof-instrumentation-flag branch November 20, 2023 17:42
@Baltoli Baltoli mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtrepta gtrepta gtrepta approved these changes

@theo25 theo25 theo25 approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Baltoli @theo25 @gtrepta @rv-jenkins