Remove unused strict
field from ParseInModule
#3807
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
strict
field inParseInModule
.The field is safe to remove because, after eliminating some dead code,
strict
inParseInModule
is inparseStringTerm
strict
is (almost) always set totrue
strict
is set tofalse
is through a few calls toRuleGrammarGenerator.getCombinedGrammar
inKPrint
. However, these usages only ever callgetParsingModule
andgetExtensionModule
on the constructedParseInModule
object, neither of which invokesparseStringTerm
, so the value ofstrict
here is actually irrelevant.Note that no actual functionality is lost either - the only live usage of
strict
inparseStringTerm
is now fully controlled by theinferSortChecks
argument rather thanstrict && inferSortChecks
.