Remove mavenix take 2 #3806
Merged
Remove mavenix take 2 #3806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upcoming nixos 23.11 stable release
| buildPhase = '' | ||
| runHook preBuild | ||
| '' + lib.optionalString buildOffline '' | ||
| mvn org.apache.maven.plugins:maven-dependency-plugin:3.6.1:go-offline -Dmaven.repo.local=$out/.m2 ${mvnDepsParameters} |
There was a problem hiding this comment.
using latest version of the go-offline plugin which does not build snapshot jars of the local project
There was a problem hiding this comment.
Um, you're not 100% requiring every single dependency to be pulled in by this, are you? go-offline has bugs that means it pulls in most of the dependencies, but not 100%. So if this is going to cause something to break if one or two dependencies isn't included in this, this solution isn't going to work.
Comment on lines
+41
to
+42
| -o -name \*.snapshots.xml \ | ||
| -o -name \*.snapshots.xml.sha1 \) \ |
There was a problem hiding this comment.
we still get ....snapshots.xml files which contain dates of the latest snapshot, which we need to remove to make the build (hopefully) deterministic
Baltoli
approved these changes
Nov 10, 2023
goodlyrottenapple
changed the title
goodlyrottenapple
changed the title
rv-jenkins
pushed a commit
that referenced
this pull request
Nov 16, 2023
The refactor of the K derivation in #3806 broke the booster integration test shell, because we stopped wrapping llvm-backend bins with the `NIX_LLVM_KOMPILE_LIBS` env var. This PR restores that functionality and I have confirmed this fixes the integration tests in booster.
This was referenced Dec 7, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from using mavenix to using
buildMavenPackageback-ported from the upcoming nixpkgs 23.11 stable release. This may increase build times somewhat and updating maven dependencies will no longer be automatic, but arguably the automation never works and It's difficult to figure out why it's failing.I've updated the README troubleshooting section with the two cases of manual intervention, necessary with the new packaging solution, when maven dependencies change.
The hash mismatch should only happen when deps change, but if we want to automate this in ci then we can do something similar to: https://github.com/runtimeverification/hs-backend-booster/blob/175f10b16ad50dd2bb50fcfe68cbcacd79760317/scripts/update-haskell-backend.sh#L21C3-L22