Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version of mavenix #3795

Closed
wants to merge 1,113 commits into from
Closed

Fix version of mavenix #3795

wants to merge 1,113 commits into from

Conversation

goodlyrottenapple
Copy link
Contributor

Fix for a regression in kup binary packages, introduced when we switched back to a custom version of mavenix. This was done because we want to be able to manually specify the path to mavenix.lock (see nix-community/mavenix@0cbd57b). However, the next commit (nix-community/mavenix@c2f3618) is what causes the regression, by symlinking to many small nix store paths which take a very long time to download from the binary cache...

@rv-jenkins rv-jenkins changed the base branch from master to develop November 7, 2023 13:26
@radumereuta
Copy link
Contributor

@goodlyrottenapple you need to rebase your changes onto develop instead of master.

@goodlyrottenapple goodlyrottenapple deleted the sam/mavenix-version-fix branch November 7, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants