Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven plugin for using google-java-format #3793

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Conversation

gtrepta
Copy link
Contributor

@gtrepta gtrepta commented Nov 6, 2023

This just adds a maven phase for running the google-java-format tool from the command line.

Can be invoked with mvn process-sources

@gtrepta gtrepta force-pushed the maven-google-format branch from f548fbb to 30783bf Compare November 13, 2023 19:28
Copy link
Contributor

@Baltoli Baltoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and it seems to work nicely; @goodlyrottenapple's changes to the Maven build also look like they're working properly.

@gtrepta feel free to merge!

@Baltoli Baltoli marked this pull request as ready for review November 14, 2023 16:02
@rv-jenkins rv-jenkins merged commit ddefb21 into develop Nov 14, 2023
8 checks passed
@rv-jenkins rv-jenkins deleted the maven-google-format branch November 14, 2023 17:03
@Baltoli Baltoli mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants