Update Bencher's version #3792
Merged
Update Bencher's version #3792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radumereuta
approved these changes
Nov 6, 2023
|
lgtm, although something broke. |
Thanks, Radu, I was missing an environment flag needed in the newest Bencher version! |
Baltoli
approved these changes
Nov 7, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3738
This PR updates the bencher's version to use the new
--branchfeature ofbencher report listto filter the reports and fix the branch name to get thebranch slugexpected for Bencher to correctly search for the branch as it replaces the special character/by-and drops_at the beginning of the string.