Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply more automatic Java refactoring #3785

Merged
merged 5 commits into from
Nov 6, 2023
Merged

Apply more automatic Java refactoring #3785

merged 5 commits into from
Nov 6, 2023

Conversation

Baltoli
Copy link
Contributor

@Baltoli Baltoli commented Nov 1, 2023

This PR applies a few small simplifications suggested by IntelliJ:

  • Expression lambdas
  • Removal of dead-code default cases in switches
  • Simplification of stream + optional call chains (removal of redundant calls etc.)

Copy link
Contributor

@radumereuta radumereuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one question

Copy link
Collaborator

@Robertorosmaninho Robertorosmaninho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this!

@rv-jenkins rv-jenkins merged commit 8b6ccbc into develop Nov 6, 2023
9 checks passed
@rv-jenkins rv-jenkins deleted the more-refactoring branch November 6, 2023 18:03
@Baltoli Baltoli mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants