Revert #3773 #3779
Merged
Revert #3773 #3779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5c2cbe9.
Baltoli
requested review from
theo25,
dwightguth,
radumereuta,
Scott-Guest,
tothtamas28,
goodlyrottenapple,
Robertorosmaninho,
F-WRunTime,
geo2a and
jberthold
geo2a
approved these changes
Oct 31, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a direct revert of #3773 that we need to merge to fix the release build; the original issue fix in that PR didn't work as I expected and so we will need to consider a more involved strategy to clean this file out of the repository.