Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README instructions #3761

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Update README instructions #3761

merged 6 commits into from
Oct 27, 2023

Conversation

Baltoli
Copy link
Contributor

@Baltoli Baltoli commented Oct 26, 2023

This PR makes a few small changes to the K developer README:

  • Updates the Apple M1/M2 build instructions to reflect that we can now build from source on those machines with a small workaround (fixes Update Apple M1/2 K build instructions #3726)
  • Removes the old / deprecated non-flake Nix build instruction
  • Removes mentions of Eclipse; I don't believe anyone is still using it to develop K
  • Removes a dead link

@Baltoli Baltoli requested a review from dwightguth October 26, 2023 14:57
@Baltoli Baltoli linked an issue Oct 26, 2023 that may be closed by this pull request
Update Apple M1/2 K build instructions #3726
Closed
goodlyrottenapple
goodlyrottenapple reviewed Oct 26, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
Robertorosmaninho
Robertorosmaninho approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@Robertorosmaninho Robertorosmaninho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the ensure typo. LGTM!

@Baltoli @goodlyrottenapple
Update README.md
35ea7c9 
Co-authored-by: Samuel Balco <[email protected]>
@rv-jenkins rv-jenkins merged commit d81ecb8 into develop Oct 27, 2023
8 checks passed
@rv-jenkins rv-jenkins deleted the m1-build branch October 27, 2023 09:42
@radumereuta radumereuta mentioned this pull request Nov 7, 2023
Closed
5 tasks
@Baltoli Baltoli mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robertorosmaninho Robertorosmaninho Robertorosmaninho approved these changes

@goodlyrottenapple goodlyrottenapple goodlyrottenapple approved these changes

@dwightguth dwightguth dwightguth approved these changes

@radumereuta radumereuta Awaiting requested review from radumereuta

@Scott-Guest Scott-Guest Awaiting requested review from Scott-Guest

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Apple M1/2 K build instructions
5 participants
@Baltoli @dwightguth @goodlyrottenapple @Robertorosmaninho @rv-jenkins