Test K version output on packaging #3692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robertorosmaninho
force-pushed
the
fix-and-test-k-version
branch
from
fa7905e to
928ac58
Compare
Robertorosmaninho
changed the title
|
Fixed with #3691 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3691.
This PR creates a simple test on the
test-packageto check whether a modification on K breaks the--versionoutput, as the current regression test couldn't catch recent problems with it.The test is pretty simple: it uses the old system of getting
--versionfrom the JVM execution ofkserverand checks it against thekompile --versionthat uses the k script implementation that avoids JVM startup to output the tool's version. If they are the same, the test succeeds and fails otherwise!This PR should fail until #3691 gets merged!