change case classes and parser to support multi-ary \and/\or. #3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this stage, actually parsing a multi-ary term will lead to an internal representation that is handled incorrectly by all the code that interprets KORE. However, this change ought to pass CI and be sufficient to be able to modify the llvm backend without anything breaking.
Robertorosmaninho
approved these changes
Sep 28, 2023
dwightguth
pushed a commit
to runtimeverification/llvm-backend
that referenced
this pull request
Sep 29, 2023
Blocked on runtimeverification/k#3676 This PR implements the changes to the scala code in the llvm backend to support multi-ary and and or. In order to do this without the second wave of changes to the frontend, we rely on a slightly messy approach that involves breaking the abstraction barrier of the scala code in the frontend. this will be cleaned up by a later PR that will revert the first of the two commits in this PR. --------- Co-authored-by: rv-jenkins <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this stage, actually parsing a multi-ary term will lead to an internal representation that is handled incorrectly by all the code that interprets KORE. However, this change ought to pass CI and be sufficient to be able to modify the llvm backend without anything breaking.