Ordering instance for Sentences (2) #3670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtrepta
requested review from
radumereuta,
Robertorosmaninho and
dwightguth
radumereuta
approved these changes
Sep 28, 2023
Robertorosmaninho
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
I've tested this locally (on MacOS13 M1), and it passes all tests, including the one that was failing previously on the release. Be free to label automerge on it if you like @gtrepta.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3530
This branch was merged and then reverted because of an issue that didn't get caught earlier in CI. I have since pushed a fix for the issue and tested it to make sure that it will work. So, this should be good to go. But if we really want to be sure, then we can consider this PR blocked on #3669.