Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Maven and Testing it #3664

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Updating Maven and Testing it #3664

merged 1 commit into from
Sep 26, 2023

Conversation

Robertorosmaninho
Copy link
Collaborator

@Robertorosmaninho Robertorosmaninho commented Sep 25, 2023 •
edited
Loading

This simple PR updates the Maven version to fix the failing Release CI that builds Homebrew formulae.

@rv-jenkins rv-jenkins changed the base branch from master to develop September 25, 2023 22:10
@Robertorosmaninho Robertorosmaninho self-assigned this Sep 25, 2023
@Robertorosmaninho Robertorosmaninho temporarily deployed to production September 26, 2023 12:29 — with GitHub Actions Inactive
@Robertorosmaninho Robertorosmaninho marked this pull request as ready for review September 26, 2023 14:12
dwightguth
dwightguth approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@dwightguth dwightguth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine assuming the tests pass. If they don't, ask for my review again after fixing them.

@Robertorosmaninho Robertorosmaninho added automerge dependencies Pull requests that update a dependency file labels Sep 26, 2023
@rv-jenkins rv-jenkins merged commit 57d7bba into develop Sep 26, 2023
@rv-jenkins rv-jenkins deleted the update-scala-compiler branch September 26, 2023 15:03
@Baltoli Baltoli mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwightguth dwightguth dwightguth approved these changes

@radumereuta radumereuta Awaiting requested review from radumereuta

Assignees

@Robertorosmaninho Robertorosmaninho

Labels
automerge dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Robertorosmaninho @dwightguth @rv-jenkins