Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing develop.yml workflow #3655

Merged
merged 5 commits into from
Sep 21, 2023
Merged

Fixing develop.yml workflow #3655

merged 5 commits into from
Sep 21, 2023

Conversation

Robertorosmaninho
Copy link
Collaborator

@Robertorosmaninho Robertorosmaninho commented Sep 20, 2023

This PR fixes the develop workflow by:

  • Modifying the post_results_to_develop.py script to get only the branch's name without the user and adding one more logging message.
  • Modifying the develop.yml to set the ${COMMIT_SHA} env variable and use it as a parameter to the above script, so we don't have to use the git command inside the container raising ownership issues and fixing a mismatch of ' and " on the bencher run posting command.

@Robertorosmaninho Robertorosmaninho self-assigned this Sep 20, 2023
@rv-jenkins rv-jenkins changed the base branch from master to develop September 20, 2023 17:40
@Robertorosmaninho Robertorosmaninho marked this pull request as ready for review September 21, 2023 14:06
@Robertorosmaninho Robertorosmaninho requested a review from a team as a code owner September 21, 2023 14:06
@rv-jenkins rv-jenkins merged commit 7c0bc44 into develop Sep 21, 2023
10 of 16 checks passed
@rv-jenkins rv-jenkins deleted the test-develop-workflow branch September 21, 2023 20:24
@Baltoli Baltoli mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants