Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-pr workflow doesn't run tests on MacOS #3669

Open
gtrepta opened this issue Sep 27, 2023 · 3 comments
Open

test-pr workflow doesn't run tests on MacOS #3669

gtrepta opened this issue Sep 27, 2023 · 3 comments

Comments

@gtrepta
Copy link
Contributor

gtrepta commented Sep 27, 2023

The test-pr workflow currently only runs tests on Linux and Nix. Tests aren't ran on a MacOS system until the release workflow, which led to us not catching an issue with a PR for #3530 until after it was merged.
@gtrepta gtrepta mentioned this issue Sep 27, 2023
Merged
@ehildenb
Copy link
Member

Sounds like we need to:

It sounds like just running any test wouldn't have caught this problem, we need to run the whole test-suite.

rv-jenkins added a commit that referenced this issue Sep 30, 2023
@gtrepta @rv-jenkins
Ordering instance for Sentences (2) (#3670)
c71f50d 
fixes: #3530 

This branch was merged and then reverted because of an issue that didn't
get caught earlier in CI. I have since pushed a fix for the issue and
tested it to make sure that it will work. So, this should be good to go.
But if we really want to be sure, then we can consider this PR blocked
on #3669.

---------

Co-authored-by: rv-jenkins <[email protected]>
@Baltoli Baltoli self-assigned this Nov 2, 2023
@Baltoli
Copy link
Contributor

Baltoli commented Nov 2, 2023

I will start to take a look at dropping Homebrew packaging and instead only building K locally in the test CI.

@Baltoli
Copy link
Contributor

Baltoli commented Dec 20, 2023

Currently blocked on disabling Z3 in type inference for good.

@Baltoli Baltoli closed this as completed Dec 20, 2023
@Baltoli Baltoli reopened this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Baltoli @ehildenb @gtrepta @F-WRunTime