Skip to content

Commit

Permalink
modified: .github/workflows/master-pr.yml
Browse files Browse the repository at this point in the history
modified:   .github/workflows/test-pr.yml
- Trying a different approach to triggers to support triggering full
  test-pr.yml on update of change branch target, without using PATs /
Github App.
  • Loading branch information
F-WRunTime committed Nov 25, 2024
1 parent f28be4a commit b5d41fb
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/master-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
run: |
set -x
pull_number=$(jq --raw-output .pull_request.number "${GITHUB_EVENT_PATH}")
comment_body='The target branch has been updated from master > develop. Thank you for your support!'
comment_body='Target Branch Changed! Thank you for your support!'
curl -X POST \
-H "Accept: application/vnd.github+json" \
-H "Authorization: Bearer ${GITHUB_TOKEN}" \
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/test-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,15 @@ on:
types: [opened, reopened, synchronize]
branches:
- 'develop'
workflow_run:
workflows: ['Configure PR']
types:
- completed
issue_comment:
types: [created]
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
format-check:
if: ${{ github.event_name == 'pull_request' || (github.event_name == 'issue_comment' && github.event.comment.body == 'Target Branch Changed! Thank you for your support!') }}
name: 'Java: Linting'
runs-on: ubuntu-latest
steps:
Expand All @@ -33,6 +32,7 @@ jobs:


pyk-code-quality-checks:
if: ${{ github.event_name == 'pull_request' || (github.event_name == 'issue_comment' && github.event.comment.body == 'Target Branch Changed! Thank you for your support!') }}
name: 'Pyk: Code Quality & Unit Tests'
runs-on: ubuntu-latest
timeout-minutes: 5
Expand All @@ -59,6 +59,7 @@ jobs:


code-quality:
if: ${{ github.event_name == 'pull_request' || (github.event_name == 'issue_comment' && github.event.comment.body == 'Target Branch Changed! Thank you for your support!') }}
name: 'Code Quality Checks'
runs-on: ubuntu-latest
needs:
Expand Down

0 comments on commit b5d41fb

Please sign in to comment.