-
Notifications
You must be signed in to change notification settings - Fork 152
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid overlap of equations for Bool combinators simplifications (#3789)
This is a variant of #3786 which turns all equations that focus on the 2nd argument of a `Bool` combinator as `simplification`s. In doing this, we retain a complete set of defining equations but avoid the problem described below. Equations are kept in groups by combinator, rather than splitting them into defining and simplification equations in different modules. ------------------- Rules like this pair ``` rule false andBool _:Bool => false rule _:Bool andBool false => false ``` were previously in `BOOL-COMMON` and were said to demonstrate the implemented semantics of the hooks. As `kore-rpc-booster` does not have its own hooks, the rules now come into effect themselves. This causes issues because of the obvious overlap of rule matches (consider subject term `false andBool false` which matches both rule LHSs). This PR addresses the `kore-rpc-booster` issue by declaring some of the rules for `Bool` combinators as `simplification`s (whose application is optional - simplifications are trusted to be sound regardless of their (priority) order, whereas function equations with overlapping cases or uncertain matches lead to aborting evaluation in `kore-rpc-booster` to avoid unsoundness). Also removed some trailing whitespace from the `domains.md` file. --------- Co-authored-by: Bruce Collie <[email protected]>
- Loading branch information
Showing
1 changed file
with
28 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters