HOTFIX Make some informative warning logs optional, comment about implies #4072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lies The `logMessage'` function, which emits log messages _unconditionally_, was used for logging some exception conditions in booster. However, these warnings should not appear by default in user-facing output when booster is called through the proxy and just falls back to using kore-rpc. The changes do not remove the log messages, they are now emitted at context `[proxy]`, which is a common and recommended log setting to see what the server is up to. Besides changing the `logMessage'` calls, a comment is added to point out where the incompleteness of the `implies` endpoint is rooted in the code.
geo2a
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
logMessage'function, which emits log messages unconditionally, was used for logging some exception conditions in booster. However, these warnings should not appear by default in user-facing output when booster is called through the proxy and just falls back to using kore-rpc.The changes do not remove the log messages, they are now emitted at context
[proxy], which is a common and recommended log setting to see what the server is up to.Besides changing the
logMessage'calls, a comment is added to point out where the incompleteness of theimpliesendpoint is rooted in the code.