Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn Pattern into #Bottom if any constraint is literal false #4069

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

geo2a
Copy link
Collaborator

@geo2a geo2a commented Oct 30, 2024

  • before returning a "simplify" response, check if any constrains are false and return #Bottom in that case
  • when simplifying rewriting results, prune branches if there's a literal false
    • this triggers the change in the test-vacuous integration test, where the original state is now returned. simplifyP now returns Nothing for the result and thus we get to return RewriteTrivial from performRewrite
    • note that the outdated responses for this integration tests actually had a literal false as one of the constraints.

@geo2a geo2a requested a review from jberthold October 30, 2024 10:56
@geo2a geo2a marked this pull request as ready for review October 30, 2024 10:56
@geo2a
Copy link
Collaborator Author

geo2a commented Oct 30, 2024

No difference in KEVM performance (empty table).

Copy link
Member

@jberthold jberthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jberthold jberthold merged commit f1e3717 into master Oct 30, 2024
6 checks passed
@jberthold jberthold deleted the booster-bottom-on-false-constaint branch October 30, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants