Proof queue #2147
Proof queue #2147
Conversation
| KEVM_PYK_DIR := ./kevm-pyk | ||
| KEVM_PYK_DIR := $(abspath ./kevm-pyk) |
There was a problem hiding this comment.
Why is this change needed? Also, why is poetry.lock updated? These changes should probably be backed out, should only be updated by the auto-updater.
There was a problem hiding this comment.
My version of Poetry (I think it is 1.6.1) complained about a relative path and this fixed it. I will try reverting poetry.lock and see whether it still works.
|
|
||
| def get_a_ready_id() -> str | None: | ||
| for job_label in remaining_job_labels: | ||
| if set({d.claim.label for d in id_to_job[job_label].dependencies}).issubset(finished_job_labels.keys()): |
There was a problem hiding this comment.
What if the dependency was finished in a prior job, and we just need to read from disk that it's the case? Will this catch that? It seems here that it will only work if it was proved in this session, not if it was proved in a prior session. Is that the case?
There was a problem hiding this comment.
I didn't think about that; you are probably right.
|
CLosing due to age. |
We add a queue containing proof tasks; a worker process, whenever is ready, will read a proof task from the queue and calls the prover on it. This mechanism is disabled when there is only one proof task to perform.
Subsumes #2094