Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency: kevm-pyk/src/kevm_pyk/kproj/plugin #2095

Closed

Conversation

rv-jenkins
Copy link
Contributor

No description provided.

@ehildenb
Copy link
Member

@dwightguth any idea what's going on here? This is also blocking other PRs I guess now (eg. #2092). Maybe the two PRs need to be put together, since it's updating K and blockchain-k-plugin at the same time, and they need to sync to being updated to the same K....

@ehildenb
Copy link
Member

I've cherry pickede the blockchain update to this PR: #2092, so this one likely can be closed if that one goes throug.h

@dwightguth
Copy link
Collaborator

I mean, this is kind of what I would expect to happen if you have two different submodules or pinned commits of the same repo in different parts of the recursive dependency tree of a single repo. So the solution is I guess, maybe, don't do that? Not immediately helpful for the situation you're in, I'm aware, but this type of dependency hell is going to happen under that particular scenario. If you don't want to commit to the invariant that any given repo only depends on one version of any given other repo, this is the sort of thing you'll have to work through.

@ehildenb
Copy link
Member

Yeah, that's obvious. Thank you.

I meant more to ask, are there changes that need to happen (in the other PR), other than cherry picking the change to blockchain-k-plugin dependency over to there?

As far as fixing the dependency diamond issue, my personal opinion is that it's not worth it, since this particular problem has happened once in, how long? Maybe a year or two? But open to suggestions.

@ehildenb
Copy link
Member

Changes subsumed here: #2092

@ehildenb ehildenb closed this Sep 29, 2023
@ehildenb ehildenb deleted the _update-deps/runtimeverification/blockchain-k-plugin branch September 29, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants