Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize MCD specs taking advantage of proof dependencies #2090

Closed
wants to merge 52 commits into from

Conversation

ehildenb
Copy link
Member

@ehildenb ehildenb commented Sep 26, 2023

Blocked on: #2093

This PR takes advantage of the new proof dependency structure introduce here: #1926. In particular:

  • For each contract in MCD, a new spec CONTRACT-ARITHMETIC-SPEC is created containing the internal arithmetic functions.
  • For each proof in MCD, it imports the needed specs from the arithmetic spec or other contract specs.
  • Master specs are created for each contract importing all the individual behavior specs.
  • A single master spec is created for the MCD proof suite that imports all the contract specs.
  • Update the proof harness to only run the single master spec.
  • Proofs that are not passing are disabled (and their dependents).

This takes advantage of the topological sort on proof claims which allows discharging them in dependency order, and speeds up overall execution. The goal here is to provide a robust test of subproof structure.

@ehildenb ehildenb self-assigned this Sep 26, 2023
ehildenb and others added 29 commits June 1, 2024 14:45
ehildenb added 22 commits June 5, 2024 20:03
@ehildenb ehildenb closed this Jun 5, 2024
@ehildenb ehildenb deleted the mcd-arithmetic branch June 5, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant