chore: add longform boolean unit tests #1186
Open
+75
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderbirju
force-pushed
the
add-longform-unit
branch
4 times, most recently
from
1d9e868
to
259a8c7
Compare
coderbirju
force-pushed
the
add-longform-unit
branch
4 times, most recently
from
56ac24c
to
60a51c4
Compare
| @@ -1171,6 +1171,37 @@ func TestNerdctlCommand_run(t *testing.T) { | |||
| c.EXPECT().Run() | |||
| }, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
we should include all long form flags supported by nerdctl in the check, irrespective of the ones present in our dictionary.
There was a problem hiding this comment.
--debug
--debug-full
--experimental
--insecure-registry
--attach
--detach
--interactive
--oom-kill-disable
--privileged
--read-only
--init
--rm
--sig-proxy
--tty
These are the long form boolean commands available on nerdctl. (nerdctl run --help | grep -- '--' | grep -v -E 'string|int|float|uint|uint16' | grep -v '=')
I have included everything except
--debug - since debug-full is already present
--insecure-registry - this is a pull specific flag
--attach - contradicts detach
It is important to note that certain global commands --experimental and --debug-full result in the boolean value being sent as argument instead of an equality sign (e.g --debug-full false), it is valid nerdctl command though. Just something to note.
coderbirju
force-pushed
the
add-longform-unit
branch
9 times, most recently
from
a8e1094
to
87b99bd
Compare
Signed-off-by: Arjun Raja Yogidas <[email protected]>
coderbirju
force-pushed
the
add-longform-unit
branch
from
87b99bd
to
8de1d66
Compare
sondavidb
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.