feat: make finch config available in VM at $HOME/.finch #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NerdctlConfigApplier updates the user's bash rc in the VM to point DOCKER_CONFIG to the mounted .finch dir from the host OS. This works when the bash rc is loaded, but doesn't work for, e.g., systemd user services. This change makes the finch config available available at $HOME/.finch in the VM so there is a clear place to load config via systemd user services without relying on any bash rcs. Signed-off-by: Kern Walster <[email protected]>
Shubhranshu153
approved these changes
Nov 12, 2024
|
Unit test needs to be fixed, others are flaky, rerun will fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
NerdctlConfigApplier updates the user's bash rc in the VM to point DOCKER_CONFIG to the mounted .finch dir from the host OS. This works when the bash rc is loaded, but doesn't work for, e.g., systemd user services.
This change makes the finch config available available at $HOME/.finch in the VM so there is a clear place to load config via systemd user services without relying on any bash rcs.
Testing done:
Verified the updated unit test
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.