Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(output): preserve directory structure in output (fix issue #13) #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smhagit
Copy link

@smhagit smhagit commented May 6, 2021

Introduce a new parameter to preserve the output directory structure (if the input is a directory).
The new preserveStructure parameter defaults to false to don't break any existing CI/CD scripts which rely on the previous (put all in one directory) behaviour.

I bumped the version from 2.2.0 to 2.3.0.

This resolves issue #13

…n#13)

Change-Id: Ic6da54ffac9ce8e19e63a6a08d63858079f434d1
@runegan
Copy link
Owner

runegan commented May 10, 2021

Great job! Thank you! I haven't been able to test the new functionality, but it seems to be backwards compatible at least.

Could you write one or two tests for it in "test.js", where it tests if it creates the desired output with an input? And testing it with "npm test"

I'm also trying to keep the code uniform, on smhagit-preserve-structure I've run eslint to apply the styling. So it would be great if you could merge with that.

Hope that is doable.

Thank you for the pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants