Add framework integration for composite retrieval #17536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabhdesai
changed the title
| create_if_not_exists=True, | ||
| # CompositeRetrievalMode.FULL will query each index individually and globally rerank results at the end | ||
| mode=CompositeRetrievalMode.FULL, | ||
| rerank_top_n=5, |
There was a problem hiding this comment.
is reranking optional?
There was a problem hiding this comment.
No it always reranks but when omitted it uses the server side default of 6
There was a problem hiding this comment.
Maybe this is a backend consideration then, but it might be nice to disable this and/or use something like relative score fusion instead (I feel the reranker can be a source of error depending on what your documents look like)
...x-indices-managed-llama-cloud/llama_index/indices/managed/llama_cloud/composite_retriever.py
Outdated
Show resolved
Hide resolved
...x-indices-managed-llama-cloud/llama_index/indices/managed/llama_cloud/composite_retriever.py
Show resolved
Hide resolved
|
|
||
| # Start retrieving context for your queries | ||
| # async .aretrieve() is also available | ||
| nodes = retriever.retrieve("What does YC do?") |
There was a problem hiding this comment.
I wonder if it'd be nice to show how to plug this into an agent using, say, a RetrieverTool or similar? Maybe in its own notebook though, up to you
logan-markewich
approved these changes
Jan 17, 2025
dosubot
bot
added
size:XL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
LlamaCloudCompositeRetrieverclass. Some refactoring to reuse code that was inLlamaCloudRetrieverNew Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
make format; make lintto appease the lint gods