Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/azure_table_storage params bug #14182

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

Falven
Copy link
Contributor

@Falven Falven commented Jun 16, 2024

Description

Fixed an issue where an incorrect number of parameters were being passed to split_large_property_value

Version Bump?

  • Yes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • I stared at the code and made sure it makes sense
  • I ran the code

Suggested Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 16, 2024
@Falven Falven force-pushed the feature/azure_table_storage branch from 569e458 to 23821e1 Compare June 16, 2024 19:16
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jun 16, 2024
Copy link
Contributor

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Falven!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 17, 2024
@nerdai nerdai merged commit 01e5173 into run-llama:main Jun 17, 2024
8 checks passed
@Falven Falven changed the title Feature/azure_table_storage Feature/azure_table_storage optimizations Jun 23, 2024
@Falven Falven changed the title Feature/azure_table_storage optimizations Feature/azure_table_storage params bug Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants