Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide rules to build Kotlin proto and grpc libraries. Currently upstream Protobuf and gRPC support only JVM-flavour Kotlin.
Fixes #139.
A few notes on implementation:
Some points which may want attention before merging:
WORKSPACE
ordering had to be rearranged a bit -grpc_extra_deps
imports its own (older) rules_kotlin which got messy.java_<type>_target
parameter on the macro - the Kotlin rules depend on the compiled Java library for the same proto, but users may want to build them separately for some reason.kt_jvm_*
under thekotlin
directory, but this doesn't seem simple to do without heavily modifying the rulegen templates. Probably not a huge problem.